Warn if AnnDataWrapper options are empty as it would result in empty list for `vc['datasets']['files']`
falexwolf opened this issue · 4 comments
I didn't find a unit test for this, but I found a notebook in the repo:
When I run it and look at the dict
I get an empty list for the files
key under datasets
.
I might be wrong, but I'm pretty sure this wasn't empty a few months ago. I tried to understand whether something might have changed, upgraded and downgraded vitessce to the latest and older versions, and played with different environments.
Before I continue debugging: Is 'files'
supposed to be populated with the storage path? And if not, where did the storage path go?
Complete json
{'version': '1.0.15',
'name': 'Test dataset',
'description': 'Test description',
'datasets': [{'uid': 'A', 'name': 'test1', 'files': []}],
'coordinationSpace': {'dataset': {'A': 'A'}, 'embeddingType': {'A': 'UMAP'}},
'layout': [{'component': 'obsSets',
'coordinationScopes': {'dataset': 'A'},
'x': 3.0,
'y': 0.0,
'w': 3.0,
'h': 6.0},
{'component': 'obsSetSizes',
'coordinationScopes': {'dataset': 'A'},
'x': 6.0,
'y': 0.0,
'w': 6.0,
'h': 6.0},
{'component': 'scatterplot',
'coordinationScopes': {'dataset': 'A', 'embeddingType': 'A'},
'x': 0.0,
'y': 0.0,
'w': 3.0,
'h': 6.0},
{'component': 'heatmap',
'coordinationScopes': {'dataset': 'A'},
'x': 0.0,
'y': 6.0,
'w': 6.0,
'h': 6.0},
{'component': 'featureList',
'coordinationScopes': {'dataset': 'A'},
'x': 6.0,
'y': 6.0,
'w': 6.0,
'h': 6.0}],
'initStrategy': 'auto'}
Context: I ran into this working on the below
This if
statement may be the issue
vitessce-python/vitessce/wrappers.py
Line 1123 in bc7b353
I have started a pull request here #357 with a test
Oh, thanks! That would make sense! I also have an integration test that populated paths. Will try it.
Ah that is a good idea, I will update the title