Logo not rendering on README
martamatos opened this issue · 4 comments
martamatos commented
In the develop branch:
Shouldn't the logo be rendering there?
yannikschaelte commented
It's a fully qualified link targeting the master branch, bc otherwise it would not show on pypi. It should show everywhere once it's merged to the main branch.
yannikschaelte commented
Oh, but @martamatos there is indeed a problem: The link should contain /main/, not /master/.
martamatos commented
It still seems smart enough to go to main automatically: https://github.com/yaml2sbml-dev/yaml2sbml/blob/main/doc/logo/logo_yaml2sbml_long.png
Is the 404 error still expected?
yannikschaelte commented
Ah good, then it should in principle work. Yes, the 404 is expected until develop is merged into main.