Option to disable event-handling
Opened this issue · 2 comments
During preequilibration and presimulation, amici only handles events at t=t0, the others are ignored. For debugging preequilibration failures, it would be convenient if one could switch off event handling also for regular simulations. The alternative would be re-importing the model without events, which is often inconvenient.
For PEtab 2.0 we will require events to be processed during preequilibration. For PEtab 1.0, this wasn't explicitly specified, but there wasn't really a reason to assume that they should not be processed. Therefore, amici's non-event-handling could be considered a bug.
If we want to keep backward compatibility, we'll have to add such an option to enable/disable event processing.
However, I think, it would be less surprising, and thus, preferable to change the default. I am not sure how many users were aware of events not being processed during preequilibration.
sounds fair