Cleanup project-specific/unused code
weigao95 opened this issue · 1 comments
weigao95 commented
As we discussed, spartan becomes messy as we have merged lots of project-specific code into the master. We should clean them up and keep only the core modules at master. In the future, each project should maintain its own fork/branch. Only code that everyone would (potentially) use can be merged into master.
After finalizing what to keep/remove, we should make PRs for the cleanup. Here is a tentative proposal.
What to keep
Robot driver and plan runner:
- catkin_projects/iiwa_driver
- catkin_projects/station_config
- catkin_projects/robot_msgs
- catkin_projects/robot_server
- catkin_projects/robot_control
- catkin_projects/drake_robot_control
- catkin_projects/wsg50-ros-pkg
- modules/spartan/utils
- modules/spartan/manipulation/schunk_driver.py
Camera driver and calibration:
- catkin_projects/camera_config
- handical
- modules/spartan/calibration
Simulation and teleop tools:
- catkin_projects/drake_iiwa_sim
- catkin_projects/simple_teleop
Visualization:
- director
- signal-scope
What to remove
Everything except above (and the dependency of above)
peteflorence commented
Thanks Wei for putting this together! Looking forward to discussing and
figuring out.
…On Fri, Jun 7, 2019 at 4:59 PM weigao ***@***.***> wrote:
As we discussed, spartan becomes messy as we have merged lots of
project-specific code into the master. We should clean them up and keep
only the core modules at master. In the future, each project should
maintain its own fork/branch. Only code that everyone would (potentially)
use can be merged into master.
After finalizing what to keep/remove, we should make PRs for the cleanup.
Here is a tentative proposal.
What to keep
Robot driver and plan runner:
- catkin_projects/iiwa_driver
- catkin_projects/station_config
- catkin_projects/robot_msgs
- catkin_projects/robot_server
- catkin_projects/robot_control
- catkin_projects/drake_robot_control
- catkin_projects/wsg50-ros-pkg
- modules/spartan/utils
- modules/spartan/manipulation/schunk_driver.py
Camera driver and calibration:
- catkin_projects/camera_config
- handical
- modules/spartan/calibration
Simulation and teleop tools:
- catkin_projects/drake_iiwa_sim
- catkin_projects/simple_teleop
Visualization:
- director
- signal-scope
What to remove
Everything except above (and the dependency of above)
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#378?email_source=notifications&email_token=ABLBBKE2NXXTM4WAKR4NLI3PZLD2TA5CNFSM4HV2KQNKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4GYKZEZA>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABLBBKAH77UTWCUMKHICT2DPZLD2TANCNFSM4HV2KQNA>
.