benmarwick/rrtools

docker login email flag not found

sahirbhatnagar opened this issue · 1 comments

I received an unknown flag error when trying to login to dockerhub using the -e flag as used in this line of the docker template:

- docker login -e $DOCKER_EMAIL -u $DOCKER_USER -p $DOCKER_PASS

The error went away when I removed the -e flag. Here is the docker login man page I referred to which doesn't have the -e or --email flag anywhere.

I don't know how to make a reproducible example of this. I could create a PR if newer users of rrtools are experiencing the same issue.

Hi Sahir, thanks, that's a great observation! I also see here https://github.com/docker/docker-ce/releases/tag/v17.06.0-ce that the email flag has been removed from that function.

Please do go ahead with a PR to remove this from the template, thanks!