Fixing BPP from 24 to 3 to fix segfault in proxy-camera/memcpy

Question

Fixing BPP from 24 to 3 to fix segfault in proxy-camera/memcpy

chrberger opened this issue 8 years ago · 8 comments

The configuration file needs to be adjusted by replacing 24 (assumed bits) with 3 (bytes representing the bytes per pixel):

Adjust detectvehicle by removing /8:

https://github.com/chalmers-revere/opendlv/blob/experiment.idiada/code/system/application/perception/src/detectvehicle/detectvehicle.cpp#L97

Activate mySharedImg.getBytesPerPixel():

https://github.com/chalmers-revere/opendlv/blob/experiment.idiada/code/system/application/perception/src/detectlane/detectlane.cpp#L89

Answer 1 · 2016-04-12T08:55:37.000Z

Doesn't 'bpp' really translate to "bits per pixel"?

Answer 2 · 2017-02-03T14:22:53.000Z

Is this solved?

Answer 3 · 2017-02-06T11:47:10.000Z

At least it's very old :) I do not remember the details, but things are working now so perhaps close?

Answer 4 · 2017-02-06T12:17:00.000Z

As far as I know, it's working but slight confusing if the bpp stands for bytes per pixel or bits per pixel.

Answer 5 · 2017-02-06T12:49:03.000Z

It should be "bits per pixel", I think it might be dangerous to mix this up. Bytes per pixel seems to be a quite odd format, we could perhaps write that as "bytesPerPixel" just to be clear. Perhaps we should also have "bpp" in the config, and then divide by 8 in the code.

Answer 6 · 2017-02-06T16:04:11.000Z

Actually by looking at https://github.com/chalmers-revere/opendlv.core/blob/master/code/core/system/proxy-camera-axis/src/Camera.cpp#L50 , it seems to be bytes per pixel... :) I hope we didn't mix this up hard...

Answer 7 · 2017-02-07T08:34:29.000Z

To use "setBytesPerPixel" is fine, but we should not use "BPP" since that could be confusing.

Answer 8 · 2017-03-25T18:24:05.000Z

@chrberger Should we do anything with this, or close it?