Harmonise "model" variable names
Closed this issue · 4 comments
zouter commented
Right now the first argument of most dynwrap functions can be:
- model
- traj
- object
- trajectory
Possible solutions:
- All to object/model
- Object/model if it is not a trajectory, traj/trajectory if it is a trajectory
Any preference @rcannood ?
zouter commented
Forgot to mention:
- dataset (for
infer_trajectory
)
zouter commented
I propose the following:
If a wrapper contains a trajectory, use trajectory
Otherwise use dataset
This makes the most sense in the two main dynwrap use cases: creating a trajectory and working with it (i.e. adding a root or calculating a dimensionality reduction), and creating a dataset and working with it (i.e. adding prior information or running a TI method)
This proposal is in branch renamefactorisation