lilab-bcb/cirrocumulus

display multiple Visium datasets on top of H&E images

Closed this issue · 9 comments

zglu commented

Hello Cirro team,
Does Cirro currently support displaying multiple Visium datasets (from different sections), each on top of an H&E image? (such as below an example from cellxgene)
Screenshot 2023-04-18 at 14 08 25
Thanks,
Zhigang

zglu commented

Thanks for the rapid development of the function. I tried with the following command but got an error:
cirro concat --output MouseBrain_concat/ V1_Adult_Mouse_Brain/V1_Adult_Mouse_Brain.h5ad V1_Mouse_Brain_Sagittal_Posterior/V1_Mouse_Brain_post_sct.h5ad

Traceback (most recent call last):
File "/Users/zlu/miniconda3/bin/cirro", line 5, in
from cirrocumulus.main import main
File "/Users/zlu/miniconda3/lib/python3.7/site-packages/cirrocumulus/main.py", line 6, in
from cirrocumulus import concat, launch, prepare_data, serve
File "/Users/zlu/miniconda3/lib/python3.7/site-packages/cirrocumulus/concat.py", line 12, in
def concat_spatial(paths: list[str], output_dir: str, ncols: int = 2):
TypeError: 'type' object is not subscriptable

What can be the problem please?

There was a bug parsing the command line arguments. Can you please update to the latest version and try again? Also, can you please use Python 3.9 or later too? Thanks.

zglu commented

Hi Joshua,

I've updated Python to 3.10 and installed the latest version of Cirro. Now the concat function works. But it seems that the row and col values in the data were swapped while the images were unchanged. For a single dataset it works in the same way. Maybe need to fix something..

Many thanks,
Zhigang
Screenshot 2023-04-21 at 19 16 29

Thanks for your reply. I'm not sure what you mean that "row and col values in the data were swapped" Are you using version 1.1.52.post1? Thanks.

zglu commented

Hi Joshua,
Yes, I installed 1.1.52.post1 fresh today. It looks like the data was rotated and doesn't overlay with the image correctly.
Screenshot 2023-04-21 at 20 28 10

Thanks. I can reproduce the error now. The row and column pixel spot coordinates are swapped for Space Ranger output prior to version 2.0. Will fix shortly.

Fixed in latest release. Thanks.

zglu commented

Fantastic. Now works beautifully. Thanks again for your prompt support, much appreciated!
Have a pleasant weekend :)
Screenshot 2023-04-21 at 21 24 24