Readthedocs error for closest(... direction_col='strand')

[ermakova]

Hi guys!

There is an error in https://bioframe.readthedocs.io/en/latest/guide-intervalops.html in the end of the Closest section. After that section, no illustrations to the code are displayed.

[gfudenberg]

Thanks for the note!
@agalitsyna can you check that the recent commit didn't create an issue here? 06b4831

[gfudenberg]

Forgot I could get the guide-intervalops into ipynb format with:
jupytext --to notebook guide-intervalops.md

It looks like we could update this by assigning 'strand' to df1, e.g.
df1['strand'] = ['+','-','+','.']

Is that the preferred solution @agalitsyna, or could we devise something that would be more informative as to how this feature works ?

[gfudenberg]

Relatedly, it looks like the order of arguments (genes,ctcf_peaks) is swapped in the last figure of: https://github.com/open2c/bioframe/blob/main/docs/tutorials/tutorial_assign_peaks_to_genes.ipynb relative to the order in the code.

I'm also wondering if there is a nice way to explain that this direction_col is only relevant for the first dataframe in closest... cc @golobor

[gfudenberg]

closed with #159