qcr/benchbot_addons

[BUG] Remote addons falsely marked as installed if "unzip" is not installed.

Closed this issue · 1 comments

zlewe commented

benchbot_addons/benchbot_addons/manager.py

Line 254 in 80f6366

run('unzip -d "%s" ".tmp.zip"' % target, **cmd_args)

If the system doesn't have unzip installed, the zip will not be extracted. However, the state of the addon will still be recorded as installed.

Potential solution:

  • return code checks
btalb commented

Thanks for a really useful bug report @zlewe .

We'll hopefully get an update out tomorrow that fixes that.

In the meantime, removing the benchbot/addons/benchbot_addons/.state file and running the installer again with unzip installed should work.

  • 👍1