ros-drivers/ros2_ouster_drivers

_range_image resize twice?

jonbakerfish opened this issue · 3 comments

jonbakerfish commented

ros2_ouster_drivers/ros2_ouster/include/ros2_ouster/processors/image_processor.hpp

Lines 96 to 99 in d59df70

_range_image.data.resize(_width * _height);
_range_image.data.resize(
_width * _height * _bit_depth /
(8 * sizeof(*_range_image.data.data())));

It seems that the first resize is useless.

SteveMacenski commented

Agreed. I’m not sure how that got in there. Can you submit a PR to remove? Happy to merge (I’m just on the go on vacation)

jonbakerfish commented

Hi @SteveMacenski , just create a PR #124 . Plz have a look :)

SteveMacenski commented

Thanks!