Camera info not being published
Closed this issue · 2 comments
It looks that the camera_info is not being published (at least on my V3.2 NAO with Naoqi 1.14) by default (when launching the node, nothing gets published there). Looking at the code I've seen two potential causes:
The first one is that the launch file sets two calibration file paths, the calibration_file_top and the calibration_file_bottom, and it loads both parameters in the init_config method but in the reconfigure it uses a 'camera_info_url' parameter which is not set by the launch. I guess there should be an assigment of the camera_info_url to one of the other paths depending on the camera source used. I suppose this may be due to the change of the structure of the parameters.
The other one is that when the camera_info_url param is set it is not published by default, but it the information is published when the calibration file url is changed via the dynamic reconfigure. Looking at the code there's an if in the reconfigure which sets the cameraInfoManager if self.config['camera_info_url'] != new_config['camera_info_url'], and I suppose that at the time of running the node this has not happened. I have not touched this as I don't know much about dynamic reconfigure nor why is that if there.
i agree!
I just filed a pull request on that issue.
@gerardcanal Can you verify that #22 works for you?
Sorry I could not try it until now. It works like a charm! :)