Build failure in Rolling build farm
jtbandes opened this issue · 6 comments
https://build.ros2.org/job/Rbin_uJ64__rosbag2_storage_mcap__ubuntu_jammy_amd64__binary/18/console
02:26:08 4: Test command: /usr/bin/python3.10 "-u" "/opt/ros/rolling/share/ament_cmake_test/cmake/run_test.py" "/tmp/binarydeb/ros-rolling-rosbag2-storage-mcap-0.1.5/.obj-x86_64-linux-gnu/test_results/rosbag2_storage_mcap/cpplint.xunit.xml" "--package-name" "rosbag2_storage_mcap" "--output-file" "/tmp/binarydeb/ros-rolling-rosbag2-storage-mcap-0.1.5/.obj-x86_64-linux-gnu/ament_cpplint/cpplint.txt" "--command" "/opt/ros/rolling/bin/ament_cpplint" "--xunit-file" "/tmp/binarydeb/ros-rolling-rosbag2-storage-mcap-0.1.5/.obj-x86_64-linux-gnu/test_results/rosbag2_storage_mcap/cpplint.xunit.xml"
02:26:08 4: Test timeout computed to be: 120
02:26:08 4: -- run_test.py: invoking following command in '/tmp/binarydeb/ros-rolling-rosbag2-storage-mcap-0.1.5':
02:26:08 4: - /opt/ros/rolling/bin/ament_cpplint --xunit-file /tmp/binarydeb/ros-rolling-rosbag2-storage-mcap-0.1.5/.obj-x86_64-linux-gnu/test_results/rosbag2_storage_mcap/cpplint.xunit.xml
02:26:08 4: /tmp/binarydeb/ros-rolling-rosbag2-storage-mcap-0.1.5/src/mcap_storage.cpp:23: Found C++ system header after other header. Should be: mcap_storage.h, c system, c++ system, other. [build/include_order] [4]
02:26:09 4: /tmp/binarydeb/ros-rolling-rosbag2-storage-mcap-0.1.5/src/mcap_storage.cpp:24: Found C++ system header after other header. Should be: mcap_storage.h, c system, c++ system, other. [build/include_order] [4]
02:26:09 4: /tmp/binarydeb/ros-rolling-rosbag2-storage-mcap-0.1.5/src/mcap_storage.cpp:25: Found C++ system header after other header. Should be: mcap_storage.h, c system, c++ system, other. [build/include_order] [4]
02:26:09 4: /tmp/binarydeb/ros-rolling-rosbag2-storage-mcap-0.1.5/src/mcap_storage.cpp:26: Found C++ system header after other header. Should be: mcap_storage.h, c system, c++ system, other. [build/include_order] [4]
02:26:09 4: /tmp/binarydeb/ros-rolling-rosbag2-storage-mcap-0.1.5/src/mcap_storage.cpp:27: Found C++ system header after other header. Should be: mcap_storage.h, c system, c++ system, other. [build/include_order] [4]
02:26:09 4: /tmp/binarydeb/ros-rolling-rosbag2-storage-mcap-0.1.5/src/mcap_storage.cpp:28: Found C++ system header after other header. Should be: mcap_storage.h, c system, c++ system, other. [build/include_order] [4]
02:26:09 4: /tmp/binarydeb/ros-rolling-rosbag2-storage-mcap-0.1.5/src/mcap_storage.cpp:29: Found C++ system header after other header. Should be: mcap_storage.h, c system, c++ system, other. [build/include_order] [4]
02:26:09 4: /tmp/binarydeb/ros-rolling-rosbag2-storage-mcap-0.1.5/src/mcap_storage.cpp:30: Found C++ system header after other header. Should be: mcap_storage.h, c system, c++ system, other. [build/include_order] [4]
02:26:09 4: /tmp/binarydeb/ros-rolling-rosbag2-storage-mcap-0.1.5/src/mcap_storage.cpp:31: Found C++ system header after other header. Should be: mcap_storage.h, c system, c++ system, other. [build/include_order] [4]
02:26:09 4: /tmp/binarydeb/ros-rolling-rosbag2-storage-mcap-0.1.5/src/message_definition_cache.cpp:21: Found C++ system header after other header. Should be: message_definition_cache.h, c system, c++ system, other. [build/include_order] [4]
02:26:09 4: /tmp/binarydeb/ros-rolling-rosbag2-storage-mcap-0.1.5/src/message_definition_cache.cpp:22: Found C++ system header after other header. Should be: message_definition_cache.h, c system, c++ system, other. [build/include_order] [4]
02:26:09 4: /tmp/binarydeb/ros-rolling-rosbag2-storage-mcap-0.1.5/src/message_definition_cache.cpp:23: Found C++ system header after other header. Should be: message_definition_cache.h, c system, c++ system, other. [build/include_order] [4]
02:26:09 4: /tmp/binarydeb/ros-rolling-rosbag2-storage-mcap-0.1.5/src/message_definition_cache.cpp:24: Found C++ system header after other header. Should be: message_definition_cache.h, c system, c++ system, other. [build/include_order] [4]
02:26:09 4: /tmp/binarydeb/ros-rolling-rosbag2-storage-mcap-0.1.5/src/message_definition_cache.cpp:25: Found C++ system header after other header. Should be: message_definition_cache.h, c system, c++ system, other. [build/include_order] [4]
02:26:09 4: /tmp/binarydeb/ros-rolling-rosbag2-storage-mcap-0.1.5/src/message_definition_cache.cpp:26: Found C++ system header after other header. Should be: message_definition_cache.h, c system, c++ system, other. [build/include_order] [4]
02:26:09 4: Category 'build/include_order' errors found: 15
02:26:09 4: Total errors found: 15
Note that this error should be suppressed: https://github.com/ros-tooling/rosbag2_storage_mcap/blob/main/CPPLINT.cfg
Although I don't see anywhere in this command line where it would load that config file:
/usr/bin/python3.10 "-u" "/opt/ros/rolling/share/ament_cmake_test/cmake/run_test.py" "/tmp/binarydeb/ros-rolling-rosbag2-storage-mcap-0.1.5/.obj-x86_64-linux-gnu/test_results/rosbag2_storage_mcap/cpplint.xunit.xml" "--package-name" "rosbag2_storage_mcap" "--output-file" "/tmp/binarydeb/ros-rolling-rosbag2-storage-mcap-0.1.5/.obj-x86_64-linux-gnu/ament_cpplint/cpplint.txt" "--command" "/opt/ros/rolling/bin/ament_cpplint" "--xunit-file" "/tmp/binarydeb/ros-rolling-rosbag2-storage-mcap-0.1.5/.obj-x86_64-linux-gnu/test_results/rosbag2_storage_mcap/cpplint.xunit.xml"
So this is somewhat confusing, but we never fail a build on https://build.ros2.org because of failing tests.
The actual error comes later, when it kicked off the Rrel_import-package job. That job, in turn, failed because of some infrastructure flakiness. I'll report that to the appropriate people internally.
Hmm, @clalancette are you saying the cpplint failures are being ignored? It still seems bad that those failures are occurring…
Hmm, @clalancette are you saying the cpplint failures are being ignored? It still seems bad that those failures are occurring…
Yes, all test errors are ignored on binary package builds. The main point of binary package builds are to build the binaries; testing should have happened on earlier steps (during PR or dev jobs). There is a reasonable argument to make that the binary jobs shouldn't even bother running the tests, but there have been various problems to doing that removal in the past (that I forget now).
Build farm appears to be fixed for now, will reopen in ros2/rosbag2 if this issue comes up again.