base_max_vel_x and the other base_* parameters are not declared
tuxnese opened this issue · 2 comments
When using the speed limit filter I have noticed that the max speed of the robot was 0.4, no matter the value of max_vel_x.
Looking at the code of the setSpeedLimit, I see:
cfg_->robot.max_vel_x = cfg_->robot.base_max_vel_x;
But the base_max_vel_x parameter and the other base_* parameters are not declared, so it is not possible to change their values. Please, correct me if I am wrong.
Why not to use directly the parameters without the base prefix?
Otherwise the base* parameters should be declared to allow their modification.
I think I got why the base* parameters are not declared. The robot base variables are just used to store the value of the max_vel_x and the other corresponding variables and they are set each time the parameters are set.
The problem is that this does not work when setting the values of the parameters at the loading of the node. So the base* variables keep their initial values. The workaround is to set the parameters once the nodes are up.