ADVRHumanoids/advr-superbuild

RBDL version is not set from Buildrbdl.cmake

Closed this issue · 8 comments

liesrock commented

RBDL is held in mercurial (hg) and I tried to set a specific version using the Builrbdl.cmake :

# rbdl 
include(YCMEPHelper)
include(FindOrBuildPackage)

ycm_ep_helper(  rbdl
                TYPE HG
                STYLE BITBUCKET
                REPOSITORY rbdl/rbdl
                TAG 338e4db
		CMAKE_CACHE_ARGS -DRBDL_BUILD_ADDON_URDFREADER:BOOL=ON
                COMPONENT external
            )

Nevertheless the superbuild is not taking the requested TAG as reported by @dkanou.

Any idea? @alaurenzi @traversaro

traversaro commented

Have you tried with the complete commit hash or with a tag?

traversaro commented

In https://github.com/traversaro/gazebo-superbuild I successfully use ycm_ep_helper with mercurial, but I always use branches names as TAG argument.

liesrock commented

Here you can find the error: https://travis-ci.com/ADVRHumanoids/MultiDoF-superbuild/builds/107606808

Looks like the TAG is not working for hash: I confirm we used it successfully with branches
rbdl_error

traversaro commented

Have you tried using 338e4dbb4fa2644af1598db9a4c95cd39b6b981a instead of 338e4db?

liesrock commented

No it does not work with tag or with the whole hash: it is always cloning to 379184776089 (v2.5) on the default branch

  • 👍1
liesrock commented

I was not able to solve it unfortunately: maybe @drdanz knows how?

drdanz commented

No idea, perhaps it is a bug in ExternalProject?
YCMEPHelper is forwarding the tag argument in the exact same way as the git tag is forwarded:

https://github.com/robotology/ycm/blob/ae223b18347a641873ca40aff482d15526ab9cde/modules/YCMEPHelper.cmake#L998-L1000

liesrock commented

Thanks for the support: since it was very strange that the clone was always happening on 379184776089 I thought there would be some other files overwriting the requested TAG.

And it was like this: ProjectTags.cmake was overwriting (we had the 379184776089 commit on it for rbdl) everything I put on Buildrbdl.cmake

Fixed in cc8c143

  • 👍2