`docker-build-and-push-main` is failing
xmfcx opened this issue · 4 comments
docker-build-and-push-main CI started failing after this was merged:
ERROR: tag is needed when pushing to registry
Error: buildx bake failed with: ERROR: tag is needed when pushing to registry
https://github.com/autowarefoundation/autoware/actions/runs/9516216183/job/26232045461#step:8:1288
Probabable cause
It has passed the test on the initial PR description:
Then, some tag related things were changed within the PR review process:
#4849 (comment)
To prevent such cases from happening, perform the tests again before merging.
Originally posted by @xmfcx in #4849 (comment)
@youtalk @oguzkaganozt @mitsudome-r I'll now start working on this task.
The test on the PR description passed:
But the workflow triggered by the commit pushed failed:
They use docker-build-and-push/action.yaml action.
The biggest difference I see between them is,
workflow_dispatchtriggered workflow that has passed,allow-push=false- push to
maintriggered workflow that has passed,allow-push=true
| Trigger | allow-push |
Workflow Status |
|---|---|---|
workflow_dispatch |
false |
✅ |
push to main |
true |
❌ |
So the test doesn't cover the allow-push=true case.
I will investigate further.