cvg/Hierarchical-Localization

Sift based local feature extraction is not working bcause of update in pycolmap.

prasad-pr-20 opened this issue · 2 comments

The local feature extractor SIFT based DOG extractor class model in hloc/extractors/dog.py seems to be now broken becuase of the update in the pycolmap.
With the latest pycolmap 0.5.0, pycolmap.sift.extract returns only two parameters while three are expected in the current code.
keypoints, scores, descriptors = self.sift.extract(image_np). Upon execution, we get the below error:

ValueError: not enough values to unpack (expected 3, got 2)

Upon performing a quick RCA, we observed that the current pycolmap i.e., 0.5.0 version, returns just keypoints and descriptors and omits scores, which is the reason for the breakdown.

Any suggestion/fix on how to obtain the score value or fix the existing solution is greatly appreciated.
Thanks in advance.

Will be fixed in #353

#353 has been merged.