Understanding why you copy the joint_ids
Opened this issue · 1 comments
brennand commented
Just wondering why you have this code throughout this code:
std::vector<uint8_t> ids(info_.joints.size(), 0);
std::copy(joint_ids_.begin(), joint_ids_.end(), ids.begin());
As the joint_ids are assigned on the init and then not modified any where else in the code base?
ijnek commented
I had a look and I think you're right, there is no point in copying and we can use joint_ids_ directly. Would you be able to submit a PR with the changes?