eric-yyjau/pytorch-superpoint

Loading pretrained weight

Closed this issue · 2 comments

ins7itia commented

Hello,
Thank you for your effort to make it!

I found something strange in Train_model_frontend.py:

pytorch-superpoint/Train_model_frontend.py

Line 201 in 86b9621

mode = "" if path[:-3] == ".pth" else "full"

I guess it checks whether the suffix is '.pth' or 'tar.gz'. If that's correct, above code should be changed like:

mode = "" if path[-4:] == ".pth" else "full"

Thanks again, please let me know if I miss something!

eric-yyjau commented

Hi @ins7itia,

Yeah you're right. Thanks for pointing out.
Sorry for the mistake. I've updated and merged to master. Please let me know how it works.

ins7itia commented

No problem at all, @eric-yyjau . Thank you for the fast feedback.

I have tested with changed code and it passed fine. I didn't test with .pth file through training since I don't have the weight, but I'm pretty sure the updated is fine! I'll close the issue:)