fallerlab/Ribo-ODDR

Target with colon

Closed this issue · 1 comments

Oligo-selector crashes if target name contains colon.

The easiest repair is probably to replace

    target=sapply(raw_df$target,FUN=function(x){return(strsplit(x,":")[[1]][1])}),
    spos=as.numeric(sapply(raw_df$target,FUN=function(x){return(strsplit(strsplit(x,":")[[1]][2], "-")[[1]][1])})),
    epos=as.numeric(sapply(raw_df$target,FUN=function(x){return(strsplit(strsplit(x,":")[[1]][2], "-")[[1]][2])})),

with

    target=sapply(raw_df$target,FUN=function(x){return(strsplit(x,":(?=[^:]+$)",perl=TRUE)[[1]][1])}),
    spos=as.numeric(sapply(raw_df$target,FUN=function(x){return(strsplit(strsplit(x,":(?=[^:]+$)",perl=TRUE)[[1]][2], "-")[[1]][1])})),
    epos=as.numeric(sapply(raw_df$target,FUN=function(x){return(strsplit(strsplit(x,":(?=[^:]+$)",perl=TRUE)[[1]][2], "-")[[1]][2])})),

I.e. replace ":" with ":(?=[^:]+$)",perl=TRUE.

Thank you very much for noticing these bugs. I'm preparing a new release which will be available upon the acceptance of our publication, and I will make sure to fix the mentioned bugs/errors you addressed here.