Unnecessary call to `buildGenericModel` in the forward dynamic solver ?

[captain-yoshi]

ROS1 Branch
I guess this call is not needed as it is already built in the init method ? This is recomputed for every control loop.

  // ForwardDynamicSolver.cpp
  
  trajectory_msgs::JointTrajectoryPoint ForwardDynamicsSolver::getJointControlCmds(
        ros::Duration period,
        const ctrl::Vector6D& net_force)
  {

    // Compute joint space inertia matrix with actualized link masses
    buildGenericModel();  // Needed ?
    m_jnt_space_inertia_solver->JntToMass(m_current_positions,m_jnt_space_inertia);
    
    ...
    
  }

[stefanscherzinger]

@captain-yoshi

Thanks for asking. If I remember correctly, there's a dynamic parameter that influences how responsive the forward simulation behaves that users may change during runtime. The buildGenericModel() call should take that into consideration.