This division by sampling time causing wrong dc gain (calculate from impulse response) in the case of discrete system with sampling time other than 1
jamestjsp opened this issue · 3 comments
Why this division by sampling time? It's causing a bug in the case of discrete system with sampling time other than 1. I am using impulse response of system for FFT convolve. This division is causing wrong DC gain. Currently I am multiplying sample time to the result of this function to correct DC gain. Is this division really required?
Line 252 in 2bfa00f
It is a convention of a unit impulse such that the first sample injects a unit of input 1./ts * ts=1. It's not necessary of course but there is a decades long of a convention behind it especially with the definition of Dirac delta.
Thank you for the clarification. Closing this issue.
No problem. keep them coming. I'm not always doing the right thing. Thus good to have a fresh pair of eyes