ros-industrial/industrial_ci

GitHub Actions: Deprecating save-state and set-output commands

fmessmer opened this issue · 7 comments

I'm not exactly sure what action needs to be taken, but as of today I'm starting to see the following deprecation notice in my CI runs:

Warning: The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

see https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

and I see set-output being used here: https://github.com/ros-industrial/industrial_ci/blob/master/industrial_ci/src/folding/github_actions.sh#L29

is it just adding around it? https://docs.github.com/en/actions/using-workflows/workflow-commands-for-github-actions#echoing-command-outputs

echo "::echo::on"
echo "::set-output name=$1::$2"
echo "::echo::on"

@fmessmer: Thanks for reporting!

If I understand it correctly,

echo "::set-output name=$1::$2"

Needs to be replaced by

    echo "$1=$2" >> "$GITHUB_OUTPUT"

(see https://docs.github.com/en/actions/using-workflows/workflow-commands-for-github-actions#setting-an-output-parameter)

@rhaschke: Please have a look as well!

@fmessmer: please check if the warning is gone now :)

thanks @mathias-luedtke
thanks @rhaschke

for fixing this so quickly - the deprecation warnings are gone 👍

peci1 commented

I'm still seeing these warnings. Is there anything I need to do to "update" industrial_ci for my repo? The workflow file is here: https://github.com/ctu-vras/ros-utils/blob/master/.github/workflows/ci.yaml . It seems to pull ici@master, which I'd guess should be sufficient.

The first warning also states:
Please update the following actions to use Node.js 16: actions/checkout@v2, actions/cache@v2

Update them to version v3!

peci1 commented

Thanks @rhaschke! That was it, so it was a false "accusation" of ICI :)