sqjin/CellChat

Incorrect documentation / use of thresh.pc argument

ATpoint opened this issue · 2 comments

Hello,

in ?identifyOverExpressedGenes() it says that for thresh.pc Threshold of the percent of cells expressed in one cluster. However, in the code on multiple occasions such as https://github.com/jinworks/CellChat/blob/main/R/utilities.R#L374 you multiply this by 100, suggesting that either the "*100" needs to be removed everywhere or documentation must state that the argument takes the a fraction rather than percentage.

best wishes!

sorry, wrong repo, will post in v2

@sqjin I suggest you make this repository an archive. It's so easy to mix up this one and the new v2. Archiving it will make it clear immediately.