Remove ROSThread and ROSThreadObject altogether from the repository

Question

Remove ROSThread and ROSThreadObject altogether from the repository

alecive opened this issue 7 years ago · 6 comments

alecive commented 7 years ago

As per title

sarimabbas commented 7 years ago

Ref: #53

Answer 1 · 2017-06-15T18:27:11.000Z

Fixed with #53

Answer 2 · 2017-06-15T18:28:03.000Z

@sarimabbas did this affect baxter_tictactoeand baxter_react_controller in any way?

Answer 3 · 2017-06-15T18:41:01.000Z

I'll just check

Answer 4 · 2017-06-15T18:46:40.000Z

No I was not able to find references to ros_thread or ros_thread_image in either repository (I searched for "thread"). However, I did see that in CMakeLists.txt of baxter_tictactoe (https://github.com/ScazLab/baxter_tictactoe/blob/master/CMakeLists.txt) on line 30, it says it needs boost::thread? Would this still be required?

Answer 5 · 2017-06-15T18:50:49.000Z

I feel it can be removed. Try to remove it , and if it compiles, just push :)