ros-drivers/openni2_camera

[CLOSED] enables proper namespacing

130s opened this issue · 3 comments

130s commented

Issue by bit-pirate
Monday Sep 16, 2013 at 07:26 GMT
Originally opened as ros-drivers/openni2_launch#6


This is similar to ros-drivers/openni_launch#2

Is there a specific reason why this hasn't been adopted for openni2_launch or has this just been missed?


bit-pirate included the following code: https://github.com/ros-drivers/openni2_launch/pull/6/commits

130s commented

Comment by mikeferguson
Monday Sep 16, 2013 at 07:49 GMT


I think this was missed when I moved over to using rgbd_launch. Name should probably be /camera/nodelet_manager, not /camera/camera_nodelet_manager, no?

130s commented

Comment by bit-pirate
Monday Sep 16, 2013 at 08:00 GMT


We kept that as it was before as we didn't see any drawbacks nor benefits. This is the same as it is in openni1_launch.

130s commented

Comment by mikeferguson
Monday Sep 16, 2013 at 08:01 GMT


ok, lgtm then