Release & Pinocchio v2
Closed this issue · 21 comments
Following discussions in stack-of-tasks/pinocchio#645 I would like to know what is the current status of this package.
Is it ready for a new release, or are you still working on it ?
I can make the release if you want, adressing #20 in the same time.
And is the pinocchio_v2 branch ready ? If so I could also merge it for the release, and publish it to robotpkg at the same moment as every other of our projects that depend on hpp-fcl / pinocchio.
Hi @nim65s , after a quick look at the (really) long discussion you had with the others, I wonder whether this really concerns me and TSID. TSID depends on pinocchio, but not on FCL because it doesn't use the collision checking features. So, should I be concerned with this discussion?
To answer your question I think TSID is ready for a new release, using the branch pinocchio_v2, which you can merge into master.
Regarding the BSD license issue #20, TSID contains the software eiquadprog which is under GPL. This might be an issue, doesn't it?
Thanks for your answers. If the branch pinocchio_v2 is ready, this is all we need.
@andreadelprete When the planning messed up (or when there is no planning) avoiding collision in the control is the nice feature...
Yes having eiquadprog inside TSID is an issue.
@olivier-stasse I will provide a solution for that as soon as possible to remove the strong dependency on EiquadProg.
@andreadelprete When the planning messed up (or when there is no planning) avoiding collision in the control is the nice feature...
sure, eventually it would be nice to add collision avoidance in TSID. I only meant that currently it's not there, so TSID wouldn't be affected by any change in HPP-FCL.
Regarding the compatibility with pinocchio-v2 I worked on a PR to update the library to pinocchio-v2.1.0.
I made a mistake and pushed directly on devel instead of my PR. Let me know if this is a problem, I will revert it if needed.
Hi @olivier-stasse, as far as I know TSID is already compatible with Pinocchio-v2. At the very least the branch pinocchio-v2 is. Moreover, @nim65s should have merged that branch into master a few weeks ago, so even master should be aligned with pinocchio-v2 now.
Actually after a quick look at the code it seems that it is devel to be aligned with pinocchio-v2. Master is still on pinocchio-v1.
Hi @andreadelprete. I did some tests today and some stuff were not working. For instance there was a lot of se3 namespace instead of pinocchio.
And i am talking about the devel branch. But maybe I missed something
#25 changed the namespace, but in master instead of devel.
I will handle that tomorrow, and make a release of TSID.
Ok, sorry my bad. Looking at #25, it seems that the branch pinocchio_v2 doing the right fix was not merged into devel.
@nim65s
I'll try to compare with the branch pinocchio_v2
@olivier-stasse So do you want to handle the merge in #33 ?
Or should we just forget about either the pinocchio_v2 branch, or @olivier-stasse 's last commits to devel ?
Well… For me, pinocchio_v2 branch is building (and tests are passing) and not devel, so I think I will use this one for the release.
Everything now looks good to me. @andreadelprete @olivier-stasse can you just review this commit: dab03d3 ?
Github overrides the link… You will have to go there #33 and then click on Merge branch 'devel' into pinocchio_v2
Everything now looks good to me. @andreadelprete @olivier-stasse can you just review this commit: dab03d3 ?
it looks good to me!
Good to me too