prabally code error

Question

prabally code error

HMX2013 opened this issue a year ago · 4 comments

HMX2013 commented a year ago

It seems that line 186 "concentric_idx_tmp++; " should be put behind line 187.

HMX2013 commented a year ago

Thanks.

Answer 1 · 2023-08-23T11:21:24.000Z

Could you please why? I don't think so, because it's the index for rings from the central to far part (maybe I have to change it to more appropriate names)

Answer 2 · 2023-08-25T00:47:04.000Z

Because the value of "num_rings_each_zone" may be bigger than 1. Therefore the ring index may be different from the zone index. For example, in variables flatness_thr_[concentric_idx], concentric_idx may be greater than 3. I think concentric_idx should be the zone index, not the ring index.

Answer 3 · 2023-08-25T01:07:12.000Z

Well, the flatness term is only applied to the closest rings, not the zone. Because we cannot discern between flat but steep slope and just non-ground, flat objects when the distance from the origin becomes large. That's why elevation and flatness are applied to the closest rings.