mrpt fails to build on 32bit architectures with 64bit time_t type
Closed this issue · 4 comments
seen with 2.11.10, the code didn't change in 2.11.12.
mrpt fails to build on 32bit architectures with 64bit time_t type, as seen with the current Debian/Ubuntu time_t 64 transitions:
In file included from /<>/python/all_mrpt_system.cpp:7:
/<>/python/src/mrpt/system/datetime.cpp: In function ‘void bind_mrpt_system_datetime(std::function<pybind11::module_&(const std::__cxx11::basic_string&)>&)’:
/<>/python/src/mrpt/system/datetime.cpp:60:96: error: address of overloaded function with no contextual type information
60 | M("mrpt::system").def("time_tToTimestamp", (mrpt::Clock::time_point (*)(const long &)) &mrpt::system::time_tToTimestamp, "Transform from standard "time_t" to TTimeStamp.\n \n\n timestampTotime_t\n\nC++: mrpt::system::time_tToTimestamp(const long &) --> mrpt::Clock::time_point", pybind11::arg("t"));
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
did you identify the relevant commit, that could be backported to 2.11.10?
It was a relatively-large PR: #1304
If all you want is to get rid of that error with a d/patch, it could be just changing these two lines:
https://github.com/MRPT/mrpt/blob/2.11.10/python/src/mrpt/system/datetime.cpp#L60
https://github.com/MRPT/mrpt/blob/2.11.10/python/src/mrpt/system/crc.cpp#L88
replacing long with time_t. I think that should be all...
It seems all builds are now OK for Debian & Ubuntu Noble, right? If not, please feel free of reopening.