lcolladotor/derfinder

rename "foldChange" => "log2FoldChange" for the column in the output regions

mikelove opened this issue · 2 comments

mikelove commented

for example, limma and edgeR give a column "logFC", DESeq gives "log2FoldChange"

                ## Calculate fold coverage vs group 1
                if(length(regionGroupMean) > 1){
                        foldChange <- vector("list", length(regionGroupMean) - 1)
                        names(foldChange) <- names(regionGroupMean)[-1]
                        for(group in names(foldChange)) {
                                foldChange[[group]] <- log2(regionGroupMean[[group]] / regionGroupMean[[1]])
                        }
                }
jtleek commented

Good idea. We would need to change downstream uses of foldChange with log2FoldChange. Could you issue a pull request with these changes made? That would be huge.

lcolladotor commented

Fixed in 78b7065