May 2020 Melodic Release
tylerjw opened this issue · 14 comments
I copied this from what I put in the moveit release issue. I don't think we need nearly as much time to push this out and I'm unsure if all these steps are necessary. Please let me know if we can drop any of them. I would like to push this out quickly though because jog_arm depends on the changes I just got back-ported here.
Timeline
- May 7 - Create Issue to decide on issues
- May 10 - Issues picked and PR(s) for backports created (jog_arm and other fixes)
- May 11 - Backport PR(s) merged, Code freeze of melodic-devel
- May 13 - Create shadow repo for testing and post on discord
- May 15 - Run bloom
Backport Discussion
Here are the changes in master that are not in melodic-devel and the one I merged. LMK if any of these should be backported, and if I'm missing any that are merged but not yet in a release so we can put them in the release notes. Anything that changes API of an existing message is struck out.
Back-Ported Changes
- Add messages to plan for sequences (#65): #74
- bump cmake version (#67)
- Change jogging drift dimensions (#63)
- Add ChangeControlDimensions.srv for moveit_jog_arm (#61)
Message API Changing Changes
Add origin Pose to CollisionObject (#69)
Add field quality to PlaceLocation (#64)
Extend MotionPlanRequest with seed trajectories (#46)
Ability to hide visualized robot states (#55)
Next release candidates (changes made for PR not yet merged in moveit)
Add service to update pointcloud octomap (#66)
Tasks (with owners)
- Create an issue to track release - @tylerjw
- Plan the possible date - @tylerjw
- Revert subframes change from melodic-devel - @rhaschke / @v4hn
- Decide on what will be backported - @rhaschke / @v4hn
- Create backport PRs - @tylerjw
- Merge backport PRs - @rhaschke / @v4hn
- Notify release section of discourse - @JafarAbdi
- Run buildfarm tests - @JafarAbdi
- Update changelogs - @mlautman
- Create tag with version number - @mlautman
- Update versions in package.xml - @mlautman
- Run bloom - @mlautman
- Publish release notes on moveit.ros.org - @mlautman
- Post to MoveIt Discourse - @mlautman
Updates
- Update: Struck out anything that changes an existing message API
- #66 moved to next release candidates
We just need to prepare a new release...
Looking at the diffs since the last release, I'm wondering why we have the subframes support in moveit_msgs, but MoveIt's melodic branch isn't supporting that. I think, we should remove the sub_frames support here before releasing into Melodic.
Apparently this change was really never released in melodic and I would propose to remove it there. @felixvd
IIRC the subframes feature was merged only into master
and not melodic-devel
because moveit_msgs shouldn't change after release. Am I missing something?
Am I missing something?
Yes, the fact that the message change was indeed merged in melodic-devel
a year ago, although the code support was never added to the main moveit repo.
Right. I never changed the target of that PR to master. Splitting the code across multiple repositories has its pitfalls :0
I have no problem with reverting it in melodic-devel and keeping the feature in master/noetic as planned.
I updated the list of potential backports to include only those that add new messages and not ones that change existing messages. Please advise on which ones I should prepare a backport for?
- Add service to update pointcloud octomap (#66)
The corresponding support in moveit/moveit#1984 is not merged yet, so no need to backport (yet?)
- Add messages to plan for sequences (#65)
@jschleicher do you want to see these messages in melodic-devel too?
I don't think there is harm in having them and even your standalone repository could use them.
- bump cmake version (#67)
This version is supported since kinetic, so this should be backported.
Let's talk about the message-changes for melodic in the next meeting, but I expect we do not want to do that.
Yes, we need the messages in melodic-devel.
@JafarAbdi It is now your turn to do the next steps. See "Making a new release" section of https://moveit.ros.org/documentation/contributing/pullrequests/
@JafarAbdi Prepared the release notes and a version bump: #77
Release PR: ros/rosdistro#24992
@rhaschke your PR to rosdistro got merged. What are the remaining steps? I'm not sure I have the right list of steps in the description for this.
We can already use the newly released package in all builds referring to the testing repos, i.e. ros-shadow-fixed
in Travis configs. If the next sync happened, the package will be available in the default repo as well. This can be checked here:
http://repositories.ros.org/status_page/ros_melodic_default.html?q=moveit_msgs