neka-nat/cupoch

CreateToPointCloud2Msg ouputting wrong error

tepsaj opened this issue · 1 comments

Hi @neka-nat,

I would like to report bug in the function CreateToPointCloud2Msg. The error is related to the width and step sizes of the point cloud of which the PointCloud2MsgInfo is to be created.

The code has IF-statement checking that the width, point step, and row step should be over 0. At the moment the error is printed everytime the variables are over 0 and not vice versa, like it was inteded.

if (info.width_ > 0 && info.point_step_ > 0 && info.row_step_ > 0) {
utility::LogError("[CreateToPointCloud2Msg] Width and Step sizes must be greater than 0.");
return;

The IF-statements should reversed so that the error is printed if the variables are under 0, like this

if (info.width_ < 0 && info.point_step_ < 0 && info.row_step_ < 0) {
    utility::LogError("[CreateToPointCloud2Msg] Width and Step sizes must be greater than 0.");
    return;
}

Sorry, that I didn't do pull request from this but I'm using the pip package so this was easier.

-tepsaj

Thanks!
I fixed it.