`make_libraries_directories` on Windows fails due to `mkdir -p`

Question

`make_libraries_directories` on Windows fails due to `mkdir -p`

pintert3 opened this issue a year ago · 3 comments

For windows CMD and Powershell, the -p is not necessary for the mkdir command, and is unrecognized. A work around I'd suggest is to check if the OS is Windows, and remove the -p in edalize/ghdl.py

Answer 1 · 2023-10-27T12:54:06.000Z

I got a temporary fix for windows users, which I've discussed in TerosTechnology/vscode-terosHDL#472 (comment)

Will need to just do an OS check to offer an alternative command.

Answer 2 · 2024-01-25T12:48:38.000Z

Wrote a response in TerosTechnology/vscode-terosHDL#472 but forgot to write here. Do we need -p at all?

Answer 3 · 2024-01-29T18:06:19.000Z

I must have missed the notification in the other issue. I haven't really over scrutinized the exact intention of the operation in the code, but from the looks of things, we're simply making library directories based on the names of the libraries. According to my knowledge, the -p would only be useful if we were likely to overwrite an existing directory. I don't know if we plan on using the same folders every time a run is triggered(haven't scrutinized enough), but if so, then it might be necessary. Otherwise, we don't need it at all cause every library seems to have it's own folder.